RE: Improve error handling for invalid slots and ensure a same 'inactive_since' time for inactive slots

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Nisha Moond' <nisha(dot)moond412(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: RE: Improve error handling for invalid slots and ensure a same 'inactive_since' time for inactive slots
Date: 2025-01-30 07:08:51
Message-ID: OSCPR01MB14966872023DFE8F4454DEB13F5E92@OSCPR01MB14966.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Nisha,

Thanks for creating a patch!

> Removed patch v1-0001. Please find the attached version 2 of 0002,
> which is now v2-0001.

ISMT error_if_invalid is set to true when the slot is using and set to false when dropping.
One exception is the slot_sync, but it has already had mechanism to handle such a slot.

I confirmed RaiseSlotInvalidationError() is removed based on comments.
I ran regression tests on my env and passed.

In total the patch looks good to me.

----------
Best regards,
Haato Kuroda

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-01-30 07:12:22 Re: Skip collecting decoded changes of already-aborted transactions
Previous Message Michael Paquier 2025-01-30 07:05:24 Re: An improvement of ProcessTwoPhaseBuffer logic