RE: Perform streaming logical transactions by background workers and parallel apply

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Perform streaming logical transactions by background workers and parallel apply
Date: 2023-01-07 05:42:59
Message-ID: OS3PR01MB5718AE486227CE3ACB844C5E94F89@OS3PR01MB5718.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Saturday, January 7, 2023 12:50 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com>
>
> On Fri, Jan 6, 2023 at 3:38 PM houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com>
> wrote:
> >
>
> Looks good, but I feel in pa_process_spooled_messages_if_required()
> function after getting the filestate the first check should be if (filestate==
> FS_EMPTY) return false. I mean why to process through all the states if it is
> empty and we can directly exit. It is not a big deal so if you prefer the way it is
> then I have no objection to it.

I think your suggestion looks good, I have adjusted the code.
I also rebase the patch set due to the recent commit c6e1f6.
And here is the new version patch set.

Best regards,
Hou zj

Attachment Content-Type Size
v76-0005-Add-a-main_worker_pid-to-pg_stat_subscription.patch application/octet-stream 9.4 KB
v76-0001-Perform-apply-of-large-transactions-by-parallel-.patch application/octet-stream 265.6 KB
v76-0002-Add-GUC-stream_serialize_threshold-and-test-seri.patch application/octet-stream 12.5 KB
v76-0003-Stop-extra-worker-if-GUC-was-changed.patch application/octet-stream 4.2 KB
v76-0004-Retry-to-apply-streaming-xact-only-in-apply-work.patch application/octet-stream 21.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message agharta agharta 2023-01-07 05:59:25 Re: Is OpenSSL AES-NI not available in pgcrypto?
Previous Message Julien Rouhaud 2023-01-07 05:37:19 Re: Schema variables - new implementation for Postgres 15 (typo)