| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Perform streaming logical transactions by background workers and parallel apply |
| Date: | 2023-01-07 08:55:31 |
| Message-ID: | CAFiTN-sgQ-K9BnMWKLR7Hm36QNjS7ZOBF6hsXJmQz5ChC0Desw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 7, 2023 at 11:13 AM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Saturday, January 7, 2023 12:50 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com>
> >
> > On Fri, Jan 6, 2023 at 3:38 PM houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com>
> > wrote:
> > >
> >
> > Looks good, but I feel in pa_process_spooled_messages_if_required()
> > function after getting the filestate the first check should be if (filestate==
> > FS_EMPTY) return false. I mean why to process through all the states if it is
> > empty and we can directly exit. It is not a big deal so if you prefer the way it is
> > then I have no objection to it.
>
> I think your suggestion looks good, I have adjusted the code.
> I also rebase the patch set due to the recent commit c6e1f6.
> And here is the new version patch set.
>
LGTM
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Esteban Zimanyi | 2023-01-07 09:31:55 | How to define template types in PostgreSQL |
| Previous Message | Peter Eisentraut | 2023-01-07 07:21:26 | Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions |