| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | RE: Added schema level support for publication. |
| Date: | 2021-06-24 06:40:47 |
| Message-ID: | OS0PR01MB61137D9AD59572CF9B1DDFD3FB079@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
I applied your V7* patch and complied it. The following warnings came out, please take a look.
>pg_publication.c:688:22: warning: ‘tables’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> funcctx->user_fctx = (void *) tables;
> ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
>describe.c: In function ‘describePublications’:
>describe.c:6479:35: warning: ‘pubtype’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> else if (has_pubtype && pubtype == PUBTYPE_SCHEMA)
For the warning in pg_publication.c, maybe we can replace the following 'else if' with 'else'.
+ else if (publication->pubtype == PUBTYPE_SCHEMA)
For the warning in describe.c, initialization of 'pubtype' is needed.
Regards
Tang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2021-06-24 06:46:03 | Re: pgbench logging broken by time logic changes |
| Previous Message | zhangjie2@fujitsu.com | 2021-06-24 06:37:48 | [Patch] change the default value of shared_buffers in postgresql.conf.sample |