| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | RE: Memory leak in WAL sender with pgoutput (v10~) |
| Date: | 2024-12-06 08:23:00 |
| Message-ID: | OS0PR01MB5716F034BA37F882368819FD94312@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, December 5, 2024 11:39 PM Euler Taveira <euler(at)eulerto(dot)com> wrote:
> Thanks for taking care of it. I suggest 2 small adjustments: (a) use
> ALLOCSET_SMALL_SIZES instead of ALLOCSET_DEFAULT_SIZES and (b) replace
> pubmemcxt with pubmemctx (that's the same abbreviation used by
> cachectx). I think you could remove 'mem' from this variable. My
> suggestions are pubcxt or pubnamescxt. Although, I prefer the former, if
> other publication elements are added to this context in the future.
Thanks for the suggestions. They make sense to me.
Please see the updated version as attached.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-memory-leak-in-pgoutput-with-publication-list.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2024-12-06 08:23:13 | RE: Memory leak in WAL sender with pgoutput (v10~) |
| Previous Message | Amit Langote | 2024-12-06 08:18:47 | Re: generic plans and "initial" pruning |