| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | RE: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY |
| Date: | 2024-12-03 04:51:38 |
| Message-ID: | OS0PR01MB5716B1D744673DD7B3B37ABD94362@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Friday, November 29, 2024 9:08 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
>
> Thanks for reviewing the patch. I have fixed the issue and updated the patch.
Thanks for updating the patch. I have reviewed and have few suggestions.
Please check the attached diff which includes:
1) Comments in CheckCmdReplicaIdentity()
* Removed some duplicate descriptions.
* Fixed the comments for the column list which I think is not correct.
* Mentioned the column list and generated column in XXX part as well.
2) Doc
* Since we mentioned the restriction for UPDATEs and DELTEs when row filter or
column list is defined in the create_publication.sgml, I feel we may need to
mention the generated part as well. So, added in the diff.
3) pub_contains_invalid_column
* Simplified one condition a bit.
Please check and merge if it looks good to you.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-improvements.patch.txt | text/plain | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-12-03 06:24:07 | Re: [18] Unintentional behavior change in commit e9931bfb75 |
| Previous Message | jian he | 2024-12-03 04:28:53 | Re: on_error table, saving error info to a table |