Re: [18] Unintentional behavior change in commit e9931bfb75

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [18] Unintentional behavior change in commit e9931bfb75
Date: 2024-12-03 06:24:07
Message-ID: 4ae32f53f2ddbc99824fc0a53b07cb93f09c9c09.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2024-12-02 at 17:25 -0500, Tom Lane wrote:
> Well, also for compatibility with our SQL parser's understanding
> of identifier lowercasing.

But why only for single-byte encodings? And why not for ICU?

> > Should I put the special case back?
>
> I think so.

Done. I put the special case back in (commit e3fa2b037c) because the
earlier commit wasn't intended to be a behavior change.

I'm still not convinced that the special case behavior is great, but a
lot of users are unaffected because they are on UTF8 anyway, so I'm
fine keeping it.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-12-03 06:27:03 Re: Memory leak in WAL sender with pgoutput (v10~)
Previous Message Zhijie Hou (Fujitsu) 2024-12-03 04:51:38 RE: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY