| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Memory leak in WAL sender with pgoutput (v10~) |
| Date: | 2024-12-05 04:31:56 |
| Message-ID: | OS0PR01MB5716A8B34418687F3FC3C2A194302@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, December 4, 2024 7:39 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Dec 04, 2024 at 06:42:55AM +0000, Zhijie Hou (Fujitsu) wrote:
> > I can try to write a patch if no one else is working on this.
>
> If you have some room to write a patch, that would be really nice.
> Thanks.
No problem. Here is the patch for the HEAD. This patch introduces a new memory
context within PGOutputData, specifically for allocating memory for
publication_names. The new memory context is nested under the logical decoding
context, ensuring it is freed at the end of decoding through
FreeDecodingContext.
I realized that this patch cannot be backpatched because it introduces a new
field into the public PGOutputData structure. Therefore, I think we may need to
use Alvaro's version [1] for the back branches.
[1] https://www.postgresql.org/message-id/202411300828.hwe55pzx5a4x%40alvherre.pgsql
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-memory-leak-in-pgoutput-with-publication-list-ca.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-12-05 04:52:19 | Re: Memory leak in WAL sender with pgoutput (v10~) |
| Previous Message | Thomas Munro | 2024-12-05 04:26:53 | Re: Cannot find a working 64-bit integer type on Illumos |