| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Japin Li <japinli(at)hotmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cannot find a working 64-bit integer type on Illumos |
| Date: | 2024-12-05 04:26:53 |
| Message-ID: | CA+hUKG+CPwNux6PmQfkhLsGKxEJOLHz_R4J+8GcB2VAWuyDH7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 5, 2024 at 4:29 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > Ahh, correction, it does define it (or else perl would have
> > complained), but it seems that meson magically puts it into the
> > compiler command line without being asked. So it is defined without
> > pg_config.h being involved, and thus earlier. Huh.
>
> That does not seem great. Compile an extension without the same
> CPPFLAGS, you silently get an ABI-incompatible module. We really
> ought to be putting these ABI-critical flags into pg_config.h.
> It's especially bad that this works differently between autoconf
> and meson builds.
It makes the whole MinGW circus worse that I'd realised:
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2024-12-05 04:31:56 | RE: Memory leak in WAL sender with pgoutput (v10~) |
| Previous Message | Michael Paquier | 2024-12-05 04:26:38 | Re: Missing LWLock protection in pgstat_reset_replslot() |