| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Subject: | RE: Collect statistics about conflicts in logical replication |
| Date: | 2024-09-03 11:23:16 |
| Message-ID: | OS0PR01MB571642A6A432D1CFD7CE86C894932@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, September 3, 2024 7:12 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Aug 30, 2024 at 12:15 PM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com>
> wrote:
> >
> > Here is V5 patch which addressed above and Shveta's[1] comments.
> >
>
> Testing the stats for all types of conflicts is not required for this patch
> especially because they increase the timings by 3-4s. We can add tests for one
> or two types of conflicts.
>
> *
> (see
> + * PgStat_StatSubEntry::conflict_count and
> + PgStat_StatSubEntry::conflict_count)
>
> There is a typo in the above comment.
Thanks for the comments. I have addressed the comments and adjusted the tests.
In the V6 patch, Only insert_exists and delete_missing are tested.
I confirmed that it only increased the testing time by 1 second on my machine.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Collect-statistics-about-conflicts-in-logical-rep.patch | application/octet-stream | 24.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2024-09-03 11:28:59 | RE: Collect statistics about conflicts in logical replication |
| Previous Message | Amit Kapila | 2024-09-03 11:12:22 | Re: Collect statistics about conflicts in logical replication |