| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | RE: Conflict detection and logging in logical replication |
| Date: | 2024-08-21 09:33:02 |
| Message-ID: | OS0PR01MB57161CEBE077E8AD1126A58C948E2@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, August 21, 2024 1:31 PM Kuroda, Hayato/黒田 隼人 <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Hou,
>
> Thanks for updating the patch! I think the patch is mostly good.
> Here are minor comments.
Thanks for the comments !
>
> 02.
> ```
> + <para>
> + The <literal>key</literal> section in the second sentence of the
> ...
> ```
>
> I preferred that section name is quoted.
I thought about this. But I feel the 'key' here is not a real string, so I chose not to
add quote for it.
>
> 0002:
>
> 03.
> ```
> -#include "replication/logicalrelation.h"
> ```
>
> Just to confirm - this removal is not related with the feature but just the
> improvement, right?
The logicalrelation.h becomes unnecessary after adding worker_intenral.h, so I
think it's this patch's job to remove this.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2024-08-21 09:34:45 | RE: Conflict detection and logging in logical replication |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-08-21 09:32:23 | RE: Conflict detection and logging in logical replication |