| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | RE: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY |
| Date: | 2024-11-19 04:20:08 |
| Message-ID: | OS0PR01MB57160A945CDAA1A601D7956894202@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, November 19, 2024 3:06 AM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> I have fixed the comments and attached an updated patch.
Thanks for the patch.
I slightly refactored the codes a bit:
* make the codes in replident_has_unpublished_gen_col()
consistent with other similar functions.
* Avoid unnecessary operations when there are no generated columns
In the table.
* Improve the loop by traversing the replica identity columns instead. I think
it looks clearer this way and better aligns with the purpose of the
replident_has_unpublished_gen_col function.
* Some cosmetic changes in the comments.
Please check the attached diff. Feel free to merge if it looks
acceptable to you.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-improve-logic.patch.txt | text/plain | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-11-19 04:44:25 | Re: Make COPY format extendable: Extract COPY TO format implementations |
| Previous Message | Thomas Munro | 2024-11-19 04:09:10 | Re: Interrupts vs signals |