Re: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY

On Tue, 19 Nov 2024 at 09:50, Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Tuesday, November 19, 2024 3:06 AM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
> >
> > I have fixed the comments and attached an updated patch.
>
> Thanks for the patch.
>
> I slightly refactored the codes a bit:
>
> * make the codes in replident_has_unpublished_gen_col()
> consistent with other similar functions.
>
> * Avoid unnecessary operations when there are no generated columns
> In the table.
>
> * Improve the loop by traversing the replica identity columns instead. I think
> it looks clearer this way and better aligns with the purpose of the
> replident_has_unpublished_gen_col function.
>
> * Some cosmetic changes in the comments.
>
>
> Please check the attached diff. Feel free to merge if it looks
> acceptable to you.
>

It looks good to me. I have added it to the latest patch.

Thanks and Regards,
Shlok Kyal