Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns

From: Matheus Alcantara <mths(dot)dev(at)pm(dot)me>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns
Date: 2022-10-25 22:45:20
Message-ID: O6GB3SIM-aNw1FgXVh0AcY-5sOsKOQrbDiBoXZxfYqP0uSQTfr87xf1nd6Lp9fWMad_1P7g0GQu-UqM_106PMpR_VsVFXGKi2CNmVzxZTXg=@pm.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Hi Hackers,
>
> I noticed that psql has no tab completion around identity columns in
> ALTER TABLE, so here's some patches for that.
>
> In passing, I also added completion for ALTER SEQUECNE … START, which was
> missing for some reason.
>
> - ilmari

Hi ilmari

I've tested all 4 of your patches, and all of them seem to work as expected.

This is my first time reviewing a patch, so let's see if more experience
hackers has anything more to say about these patches, but at first they
seem correct to me.

--
Matheus Alcantara

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2022-10-25 22:55:28 Re: [PATCH] CF app: add "Returned: Needs more interest"
Previous Message Tom Lane 2022-10-25 22:09:06 Reducing duplicativeness of EquivalenceClass-derived clauses