From: | Georgios <gkokolatos(at)protonmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | vignesh C <vignesh21(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Include access method in listTables output |
Date: | 2020-07-06 07:54:12 |
Message-ID: | ML_yRD74niFoptyl9ewfYa2EFWZHSTMNzvOKhCAdc7qX3tVHG-TKU7LjBfiCRvF2-dO2eaTJemzSkuecn4Uv_-yX9xWBpnpJnrcGUxb2zfA=@protonmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, July 6, 2020 3:12 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sun, Jul 05, 2020 at 07:13:10AM +0530, vignesh C wrote:
>
> > I'm not sure if we should include showViews, I had seen that the
> > access method was not getting selected for view.
>
> +1. These have no physical storage, so you are looking here for
> relkinds that satisfy RELKIND_HAS_STORAGE().
Thank you for the review.
Find attached v4 of the patch.
>
> ---------------------------------------------------------------------------------------------------------------
>
> Michael
Attachment | Content-Type | Size |
---|---|---|
0001-Include-AM-in-listTables-output-v4.patch | application/octet-stream | 7.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-07-06 08:01:36 | Re: A patch for get origin from commit_ts. |
Previous Message | Michael Paquier | 2020-07-06 07:45:43 | Re: Cache lookup errors with functions manipulation object addresses |