Re: Include access method in listTables output

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Georgios <gkokolatos(at)protonmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <dgrowleyml(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Include access method in listTables output
Date: 2020-07-11 13:16:43
Message-ID: CALDaNm0kF4vkcxorH2dpBpnRkcHAbOaQNhpedArgYby-LRMAhQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 6, 2020 at 1:24 PM Georgios <gkokolatos(at)protonmail(dot)com> wrote:
>
>
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Monday, July 6, 2020 3:12 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> > On Sun, Jul 05, 2020 at 07:13:10AM +0530, vignesh C wrote:
> >
> > > I'm not sure if we should include showViews, I had seen that the
> > > access method was not getting selected for view.
> >
> > +1. These have no physical storage, so you are looking here for
> > relkinds that satisfy RELKIND_HAS_STORAGE().
>
> Thank you for the review.
> Find attached v4 of the patch.

Thanks for fixing the comments.
Patch applies cleanly, make check & make check-world passes.
I was not sure if any documentation change is required or not for this
in doc/src/sgml/ref/psql-ref.sgml. Thoughts?

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2020-07-11 13:27:11 Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
Previous Message Drouvot, Bertrand 2020-07-11 12:55:57 Re: Add Information during standby recovery conflicts