Re: Remove redundant code in pl_exec.c

From: Japin Li <japinli(at)hotmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove redundant code in pl_exec.c
Date: 2022-09-09 15:49:48
Message-ID: MEYP282MB1669B47A5534B2AACC29D893B6439@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Fri, 09 Sep 2022 at 23:34, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Japin Li <japinli(at)hotmail(dot)com> writes:
>> IMO, we can invoke plpgsql_param_eval_generic in plpgsql_param_eval_generic_ro
>> to avoid the redundant.
>
> I don't like this particularly --- it puts way too much premium on
> the happenstance that the MakeExpandedObjectReadOnly call is the
> very last step in the callback function. If that needed to change,
> we'd have a mess.
>

Sorry, I don't get your mind. Could you explain it more? Thanks in advance!

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-09-09 16:07:41 Re: pg_upgrade generated files in subdir follow-up
Previous Message Euler Taveira 2022-09-09 15:47:37 Re: is_superuser is not documented