| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove redundant code in pl_exec.c |
| Date: | 2022-09-09 16:57:53 |
| Message-ID: | 159144.1662742673@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Japin Li <japinli(at)hotmail(dot)com> writes:
> On Fri, 09 Sep 2022 at 23:34, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't like this particularly --- it puts way too much premium on
>> the happenstance that the MakeExpandedObjectReadOnly call is the
>> very last step in the callback function. If that needed to change,
>> we'd have a mess.
> Sorry, I don't get your mind. Could you explain it more? Thanks in advance!
This refactoring cannot support the situation where there is more
code to execute after MakeExpandedObjectReadOnly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-09-09 16:59:50 | Re: Switching XLog source from archive to streaming when primary available |
| Previous Message | Tom Lane | 2022-09-09 16:56:41 | Re: is_superuser is not documented |