| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW |
| Date: | 2021-03-13 01:29:53 |
| Message-ID: | MEYP282MB16691A9627683144BC01C869B66E9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 08 Mar 2021 at 12:28, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Sun, Mar 7, 2021 at 10:13 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
>> Hi,
>>
>> + * EXPLAIN ANALYZE CREATE TABLE AS or REFRESH MATERIALIZED VIEW
>> + * WITH NO DATA is weird.
>>
>> Maybe it is clearer to spell out WITH NO DATA for both statements, instead of sharing it.
>
> Done that way.
>
>> - if (!stmt->skipData)
>> + if (!stmt->skipData && !explainInfo)
>> ...
>> + else if (explainInfo)
>>
>> It would be cleaner to put the 'if (explainInfo)' as the first check. That way, the check for skipData can be simplified.
>
> Changed.
>
> Thanks for review comments. Attaching v7 patch set with changes only
> in 0002 patch. Please have a look.
>
The v7 patch looks good to me, and there is no other advice, so I change
the status to "Ready for Committer".
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-13 02:46:46 | Re: pgbench: option delaying queries till connections establishment? |
| Previous Message | Justin Pryzby | 2021-03-13 01:28:20 | Re: Different compression methods for FPI |