Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW

On Sat, Mar 13, 2021 at 7:00 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
>
> On Mon, 08 Mar 2021 at 12:28, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> > On Sun, Mar 7, 2021 at 10:13 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> >> Hi,
> >>
> >> + * EXPLAIN ANALYZE CREATE TABLE AS or REFRESH MATERIALIZED VIEW
> >> + * WITH NO DATA is weird.
> >>
> >> Maybe it is clearer to spell out WITH NO DATA for both statements, instead of sharing it.
> >
> > Done that way.
> >
> >> - if (!stmt->skipData)
> >> + if (!stmt->skipData && !explainInfo)
> >> ...
> >> + else if (explainInfo)
> >>
> >> It would be cleaner to put the 'if (explainInfo)' as the first check. That way, the check for skipData can be simplified.
> >
> > Changed.
> >
> > Thanks for review comments. Attaching v7 patch set with changes only
> > in 0002 patch. Please have a look.
> >
>
> The v7 patch looks good to me, and there is no other advice, so I change
> the status to "Ready for Committer".

Thanks for the review.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com