Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption

On Thu, 16 May 2024 at 17:11, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> Hi Japin,
>
> On Thu, May 16, 2024 at 1:02 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>> AppendLimitClause() does not check the limitOption, which may be
>> LIMIT_OPTION_WITH_TIES. It simply uses the LIMIT clause.
>>
>> Here is a poc patch to verify the above.
>
> Thanks for the patch! Will review.
>

I find that the FETCH FIRST ... ROWS WITH TIES does not support type casting.
For example:

postgres=# SELECT * FROM pg_class ORDER BY relname FETCH FIRST 2::bigint ROWS WITH TIES;
ERROR: syntax error at or near "::"
LINE 1: ...ECT * FROM pg_class ORDER BY relname FETCH FIRST 2::bigint R...
^

I've made a change to support type casting in the select_fetch_first_value.

Please consider reviewing the v2 patch.

--
Regards,
Japin Li