| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
| Cc: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption |
| Date: | 2024-05-16 09:56:46 |
| Message-ID: | ME3P282MB3166168DCC7A5E51277AB34AB6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, 16 May 2024 at 17:02, Önder Kalacı <onderkalaci(at)gmail(dot)com> wrote:
> Hi Japin,
>
>>
>>
>> Here is a poc patch to verify the above.
>>
>>
> The patch looks reasonable to me, it is in line with `get_select_query_def()
> <https://github.com/postgres/postgres/blob/8aee330af55d8a759b2b73f5a771d9d34a7b887f/src/backend/utils/adt/ruleutils.c#L5745-L5752>`
> .
>
> Though, probably requires a regression test.
>
Yeah, add the regression test in v2 patch [1].
--
Regards,
Japin Li
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2024-05-16 10:55:03 | BUG #18469: OOM occurs and backend processes are kept in Zombie state. |
| Previous Message | Japin Li | 2024-05-16 09:54:03 | Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption |