From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Clean up role created in new subscription test. |
Date: | 2023-11-08 13:06:09 |
Message-ID: | FC40D564-3286-4AE7-A15A-926810300110@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
> On 8 Nov 2023, at 13:32, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2023-Nov-08, Daniel Gustafsson wrote:
>
>> Since test_setup.sql is part of the regress schedule and not pg_regress we
>> would have to implement this for each test run (regress, contribs etc), which
>> is what Peter didn't like about the original suggestion.
>
> Oh, somehow that aspect of his reply failed to register with me. I
> agree with your approach of using libpq in pg_regress then.
>
> I suppose you're just thinking of using PQexec() or whatever, run one
> query with sufficient ORDER BY, save the result, and at the end of the
> test run just run the same query and compare that they are cell-by-cell
> identical? This sounds a lot simpler than the patch you posted.
Correct, that's my plan. The rationale for the earlier patch was to avoid
adding a dependency on libpq, but with that already discussed and done we can
leverage the fact that we can run such queries easy.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2023-11-08 15:55:19 | pgsql: Call pqPipelineFlush from PQsendFlushRequest |
Previous Message | Alvaro Herrera | 2023-11-08 12:32:41 | Re: pgsql: Clean up role created in new subscription test. |
From | Date | Subject | |
---|---|---|---|
Next Message | Matthias van de Meent | 2023-11-08 13:17:00 | Re: Add new option 'all' to pg_stat_reset_shared() |
Previous Message | Tomas Vondra | 2023-11-08 12:59:55 | Re: Syncrep and improving latency due to WAL throttling |