Re: [PATCH] Add sortsupport for range types and btree_gist

> On 25 Nov 2024, at 20:40, Bernd Helmle <mailings(at)oopsware(dot)de> wrote:
>
>

Hi Bernd!

Thanks for the new patch version.

There are still some problems with tests.
0. You rely on order of test execution. "init.sql" test must prepend any other test. I doubt it is guaranteed.
1. There's a typo float8__buffering in Makefile
2. cidr type seems to be left behind
3. Tests do not seem to work when your configuration lacks injection points.

You can see how tests with injection points are excluded in other modules...

Perhaps, let's ask Michael.
Michael, we have 30 tests with checks that need injection points. But these 30 tests also test functionality that needs to be tested even in build without injection points.
Do we have to extract checks with injection point into separate regression test? So that we can exclude this test in builds without injection points.

Thanks!

Best regards, Andrey Borodin.