Re: More CppAsString2() in psql's describe.c

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: More CppAsString2() in psql's describe.c
Date: 2024-11-28 18:25:56
Message-ID: CADkLM=emOHhGwnvg3UgdGDxYZWhosCQKZ93G15VYAxsiwdwprA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
>
> LGTM, I didn't scan for omissions but the ones in the patch look right to
> me.
> I sort of wish we had a shorter macro as CppAsString2() get's pretty
> verbose
> when used frequently like this.
>

I don't quite understand the etymology of the name (it's some variation on
C++'s std::to_string, plus...something), but if I did, I'd probably find
the name less icky.

STR(), C_STR(), STRING(), and CSTRING() all seem to be available...

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey M. Borodin 2024-11-28 18:32:59 Re: [PATCH] Add sortsupport for range types and btree_gist
Previous Message Matthias van de Meent 2024-11-28 18:13:22 Re: Changing shared_buffers without restart