Re: Allow default \watch interval in psql to be configured

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow default \watch interval in psql to be configured
Date: 2025-03-26 08:05:17
Message-ID: F631241D-6160-4238-8F21-6F65E1F572FD@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 26 Mar 2025, at 08:42, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:

> The reason is probably my LANG=cs_CZ.UTF8. When I switched to LANG=C, then tests passed.
>
> The main problem is in numeric format. Czech uses the comma instead of the dot.

Thanks for investigating! The main value of the test is to test setting value
and unsetting it again, so we could just as well use an integer value like the
diff below. Does it pass for you with that instead?

diff --git a/src/bin/psql/t/001_basic.pl b/src/bin/psql/t/001_basic.pl
index 7192d96049d..739cb439708 100644
--- a/src/bin/psql/t/001_basic.pl
+++ b/src/bin/psql/t/001_basic.pl
@@ -436,12 +436,12 @@ psql_fails_like(
psql_like(
$node,
'\echo :WATCH_INTERVAL
-\set WATCH_INTERVAL 0.001
+\set WATCH_INTERVAL 10
\echo :WATCH_INTERVAL
\unset WATCH_INTERVAL
\echo :WATCH_INTERVAL',
qr/^2$
-^0.001$
+^10$
^2$/m,
'WATCH_INTERVAL variable is set and updated');
psql_fails_like(

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2025-03-26 08:18:28 Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows
Previous Message Hayato Kuroda (Fujitsu) 2025-03-26 07:47:36 RE: Fix 035_standby_logical_decoding.pl race conditions