Re: Allow default \watch interval in psql to be configured

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow default \watch interval in psql to be configured
Date: 2025-03-26 09:12:32
Message-ID: CAFj8pRDKORZ=4oxtvuB=GdFUzuTwunZS7jOxdd-qCGbMGH-jkA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

st 26. 3. 2025 v 9:05 odesílatel Daniel Gustafsson <daniel(at)yesql(dot)se> napsal:

> > On 26 Mar 2025, at 08:42, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
> > The reason is probably my LANG=cs_CZ.UTF8. When I switched to LANG=C,
> then tests passed.
> >
> > The main problem is in numeric format. Czech uses the comma instead of
> the dot.
>
> Thanks for investigating! The main value of the test is to test setting
> value
> and unsetting it again, so we could just as well use an integer value like
> the
> diff below. Does it pass for you with that instead?
>
> diff --git a/src/bin/psql/t/001_basic.pl b/src/bin/psql/t/001_basic.pl
> index 7192d96049d..739cb439708 100644
> --- a/src/bin/psql/t/001_basic.pl
> +++ b/src/bin/psql/t/001_basic.pl
> @@ -436,12 +436,12 @@ psql_fails_like(
> psql_like(
> $node,
> '\echo :WATCH_INTERVAL
> -\set WATCH_INTERVAL 0.001
> +\set WATCH_INTERVAL 10
> \echo :WATCH_INTERVAL
> \unset WATCH_INTERVAL
> \echo :WATCH_INTERVAL',
> qr/^2$
> -^0.001$
> +^10$
> ^2$/m,
> 'WATCH_INTERVAL variable is set and updated');
> psql_fails_like(
>
> --
> Daniel Gustafsson
>

yes, it is ok after this change

Pavel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-03-26 09:18:53 Re: [PATCH] Add a new pattern for zero-based months for Date/Time Formatting
Previous Message vignesh C 2025-03-26 09:12:11 Re: race condition when writing pg_control