Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c
Date: 2021-10-05 19:13:34
Message-ID: F120A906-3E13-4C5F-9AEE-8A13E8E081A6@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> 5 окт. 2021 г., в 22:08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> написал(а):
>
> Andrey Borodin <x4mmm(at)yandex-team(dot)ru> writes:
>> I'm observing a related coredump in
>> + ForeignScan *fsplan = castNode(ForeignScan, fsstate->ss.ps.plan);
>
> Could we have a test case for that please? It seems to be related
> to ANALYZE, but I'm unexcited about reverse-engineering the details.

Sure, I'll compose a repro a bit later.
It's an "ANALYZE (SKIP_LOCKED)" of a foreign table containing data that triggered varchar_input() to use ereport(ERROR).

Thanks!

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2021-10-05 19:31:55 Re: pgsql: Flexible options for BASE_BACKUP.
Previous Message Tom Lane 2021-10-05 19:08:12 Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c