Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c
Date: 2021-10-06 18:36:56
Message-ID: 4159891.1633545416@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrey Borodin <x4mmm(at)yandex-team(dot)ru> writes:
> 5 окт. 2021 г., в 22:08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> написал(а):
>> Could we have a test case for that please? It seems to be related
>> to ANALYZE, but I'm unexcited about reverse-engineering the details.

> Sure, I'll compose a repro a bit later.

Ah, never mind, I found I can duplicate it just by adding an ANALYZE
in the stanza of postgres_fdw.sql that's already checking for
conversion-error cases. Will fix.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-10-06 19:50:47 pgsql: Fix null-pointer crash in postgres_fdw's conversion_error_callba
Previous Message Tom Lane 2021-10-06 17:38:55 pgsql: Doc: improve timezone/README's recipe for tracking Windows zones