| From: | "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | RE: SIGTERM -> elog(FATAL) -> proc_exit() is probably a bad idea |
| Date: | 2001-01-14 17:03:08 |
| Message-ID: | EKEJJICOHDIEMGPNIFIJCEMODEAA.Inoue@tpf.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
>
> "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
> > Isn't it appropriate to call a diffrent macro using a separate
> > CriticalSectionCount variable in newly added places ?
>
> Why? What difference do you see in the nature of the critical sections?
> They all look the same to me: hold off cancel/die response.
>
I've thought that the main purpose of CRIT_SECTION is to
force redo recovery for any errors during the CRIT_SECTION
to complete the critical operation e.g. bt_split(). Note that
elog(ERROR/FATAL) is changed to elog(STOP) if Critical
SectionCount > 0. Postgres 7.1 stll lacks an undo functionality
and AbortTransaction() does little about rolling back the
transaction. PostgreSQL seems to have to retry the critical
operation by running a redo recovery after killing all backends.
Regards.
Hiroshi Inoue
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2001-01-14 17:21:38 | Re: SIGTERM -> elog(FATAL) -> proc_exit() is probably a bad idea |
| Previous Message | Tom Lane | 2001-01-14 16:21:51 | Re: SIGTERM -> elog(FATAL) -> proc_exit() is probably a bad idea |