Re: pgsql: Add support for coordinating record typmods among parallel worke

On September 14, 2017 8:38:09 PM PDT, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>On Fri, Sep 15, 2017 at 3:18 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Andres Freund <andres(at)anarazel(dot)de> writes:
>>> Add support for coordinating record typmods among parallel workers.
>>
>> Buildfarm not happy ...
>
>My compiler, C++ and more recent C standards are OK with identical
>redefinition of a typedef like that, but not the older standards or
>those particular compilers. D'oh. (I should figure out how to make
>my automatic patch tester this fussy). I think we should probably
>just do this:
>
>diff --git a/src/include/access/session.h
>b/src/include/access/session.h
>index 8376dc53127..910a9815d78 100644
>--- a/src/include/access/session.h
>+++ b/src/include/access/session.h
>@@ -13,9 +13,7 @@
> #define SESSION_H
>
> #include "lib/dshash.h"
>-
>-/* Defined in typcache.c */
>-typedef struct SharedRecordTypmodRegistry SharedRecordTypmodRegistry;
>+#include "utils/typcache.h"
>
> /*
>* A struct encapsulating some elements of a user's session. For now
>this

Sorry for missing that during review - unfortunately I don't have a computer with me now - so I won't get around to this till tomorrow...

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.