Re: pgsql: Add support for coordinating record typmods among parallel worke

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add support for coordinating record typmods among parallel worke
Date: 2017-09-15 04:29:48
Message-ID: 28654.1505449788@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Sorry for missing that during review - unfortunately I don't have a computer with me now - so I won't get around to this till tomorrow...

It turns out that this breaks my local build, too, so I went ahead and
pushed a fix.

At least two buildfarm members think there's something deeper broken
here:

2017-09-15 00:08:34.061 EDT [97092:75] LOG: worker process: parallel worker for PID 101175 (PID 101256) was terminated by signal 11: Segmentation fault
2017-09-15 00:08:34.061 EDT [97092:76] DETAIL: Failed process was running: select * from pg_get_object_address('operator of access method', '{btree,integer_ops,1}', '{int4,bool}');

I wonder if this indicates you forgot to consider transmission of state
to parallel worker processes.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2017-09-15 04:34:10 Re: pgsql: Add support for coordinating record typmods among parallel worke
Previous Message Tom Lane 2017-09-15 04:25:36 pgsql: Avoid duplicate typedef for SharedRecordTypmodRegistry.

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-09-15 04:34:10 Re: pgsql: Add support for coordinating record typmods among parallel worke
Previous Message Michael Paquier 2017-09-15 04:20:07 Re: [COMMITTERS] pgsql: passwordcheck: Add test suite