RE: Patch for Improved Syntax Error Reporting

From: "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Neil Padgett" <npadgett(at)redhat(dot)com>, <pgsql-patches(at)postgresql(dot)org>
Subject: RE: Patch for Improved Syntax Error Reporting
Date: 2001-08-02 02:27:22
Message-ID: ECEHIKNFIMMECLEBJFIGAEHGCBAA.chriskl@familyhealth.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> But how do they display error messages now? Can't they just continue
> doing that with this new code? Do we want to make them code their own
> error handling, and for what little benefit? Let them figure out how to
> display the error in fixed-width font and be done with it. I am sure
> they have bigger things to do than colorize error locations.

My 2c:

Why not do tom's suggestion for the POSITION: n thing, and modify psql to
strip out that header, and output the relevant part of the sql with a caret
highlighting the error position.

This will make it so that writers of the guis and format errors how they
like, and users of the most popular text interface (psql) get human-readable
results...

ie. best of both worlds...

Chris

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Barry Lind 2001-08-02 02:32:58 Re: What needs to be done?
Previous Message Barry Lind 2001-08-02 02:19:33 Re: What needs to be done?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-08-02 02:39:49 Re: Patch for Improved Syntax Error Reporting
Previous Message Bruce Momjian 2001-08-02 01:45:15 Re: Revised Patch to allow multiple table locks in "Unison"