Re: Patch for Improved Syntax Error Reporting

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Padgett <npadgett(at)redhat(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch for Improved Syntax Error Reporting
Date: 2001-08-02 02:39:49
Message-ID: 200108020239.f722dnG04126@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> > But how do they display error messages now? Can't they just continue
> > doing that with this new code? Do we want to make them code their own
> > error handling, and for what little benefit? Let them figure out how to
> > display the error in fixed-width font and be done with it. I am sure
> > they have bigger things to do than colorize error locations.
>
> My 2c:
>
> Why not do tom's suggestion for the POSITION: n thing, and modify psql to
> strip out that header, and output the relevant part of the sql with a caret
> highlighting the error position.
>
> This will make it so that writers of the guis and format errors how they
> like, and users of the most popular text interface (psql) get human-readable
> results...
>
> ie. best of both worlds...

OK, I withdraw my objection.

Also, I like the idea of adding Hints and Function/line numbers to the
output too. The offset of the error would work into that system.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-08-02 02:41:04 Re: What needs to be done?
Previous Message Barry Lind 2001-08-02 02:32:58 Re: What needs to be done?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-08-02 03:00:05 Re: ODBC Boolean handling
Previous Message Christopher Kings-Lynne 2001-08-02 02:27:22 RE: Patch for Improved Syntax Error Reporting