Re: Fix for file names with spaces

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix for file names with spaces
Date: 2005-10-05 15:35:55
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4CC31D4@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: 05 October 2005 16:31
> To: Dave Page
> Cc: Bruce Momjian; PostgreSQL-patches
> Subject: Re: [PATCHES] Fix for file names with spaces
>
> "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> writes:
> >> Why does this patch convert '\' to '\\' and not to '/' ?
>
> > Because support on Windows for / is somewhat inconsistent
> outside of the
> > Msys shell.
>
> Do we care about that for the purposes that pg_config will be
> used for?
> It seems more likely to me that emitting \\ will break things
> than that
> it will help. In particular, we know that the former behavior worked
> fine modulo the pathnames-with-spaces problem.

Well it makes no difference to me, but will might well make pg_config
useless for anyone trying to use it as part of a non-msys/cygwin based
build environment for their projects. I don't know how likely that is
though - certainly I don't try to do anything like that in my own VC++
projects, but then all of those predate 8.0 anyway.

Regards, Dave.

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-10-05 23:54:26 Re: cleanup log_disconnections()
Previous Message Tom Lane 2005-10-05 15:31:07 Re: Fix for file names with spaces