| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: cleanup log_disconnections() |
| Date: | 2005-10-05 23:54:26 |
| Message-ID: | 1128556466.9140.15.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Mon, 2005-03-10 at 12:28 -0400, Qingqing Zhou wrote:
> Ooops, this wording change is inconsistent with Log_connections, so I
> reverted it. Updated patch is attached.
Other inconsistencies:
- the patch prints a trailing comma when remote->port is the empty
string
- the patch separates the elements of the ereport() line with commas,
whereas the original behavior was to use a single space as a separator
- the original behavior was to prefix the session time with "session
time:"; the patch changed this to "session time="
The latter two changes aren't necessarily incorrect, but I reverted them
anyway, for the sake of consistency with log_connections.
A revised patch is attached -- I've applied it to HEAD.
-Neil
| Attachment | Content-Type | Size |
|---|---|---|
| log_disconnections_cleanup-3.patch | text/x-patch | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Qingqing Zhou | 2005-10-06 03:04:04 | Re: cleanup log_disconnections() |
| Previous Message | Dave Page | 2005-10-05 15:35:55 | Re: Fix for file names with spaces |