Re: [HACKERS] Dbsize backend integration

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Dawid Kuroczko" <qnex42(at)gmail(dot)com>
Cc: "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Dbsize backend integration
Date: 2005-07-04 07:38:26
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E490E8CF@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: 03 July 2005 17:10
> To: Dawid Kuroczko
> Cc: Andreas Pflug; Dave Page; Bruce Momjian;
> PostgreSQL-patches; PostgreSQL-development
> Subject: Re: [HACKERS] [PATCHES] Dbsize backend integration
>
> Dawid Kuroczko <qnex42(at)gmail(dot)com> writes:
> > Oh, I think pg_dbfile_size is best so far.
>
> I think it's by far the ugliest suggestion yet :-(

Why? It does exactly what it says on the tin! It might not be that nice,
but it does describe what it does - and noone yet has come up with
anything less ambiguous or misleading imho.

> Andreas's suggestion of having just one function with a bool parameter
> might be a workable compromise.

Aside from the fact that's a change to the API that we had settled on,
it doesn't solve the actual problem of needing a suitable name for a
function that returns the size of a table /or/ index. pg_relation_size()
or pg_table_size() can't be used for precisely the reason they were
rejected for that purpose in the first place.

Regards, Dave.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oliver Jowett 2005-07-04 10:43:14 Re: Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL
Previous Message Hannu Krosing 2005-07-04 07:24:59 Re: PATCH to allow concurrent VACUUMs to not lock each

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-07-04 07:51:50 silence GCC4 warning
Previous Message Hannu Krosing 2005-07-04 07:24:59 Re: PATCH to allow concurrent VACUUMs to not lock each