| From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: psql \! WIN32 cleanup |
| Date: | 2004-11-06 13:12:20 |
| Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E407B428@ratbert.vale-housing.co.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
-----Original Message-----
From: pgsql-patches-owner(at)postgresql(dot)org on behalf of Tom Lane
Sent: Sat 11/6/2004 5:30 AM
To: Bruce Momjian
Cc: PostgreSQL-patches
Subject: Re: [PATCHES] psql \! WIN32 cleanup
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> The attached applied patch tests for COMSPEC in the right place and
>> supplies a reasonable shell default on Win32.
>>
> + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe"
> Is it really a good idea to assume that the Windows installation is on
> drive C: ?
I think it's worse to assume the installation directory is "windows". On windows 2000 for example, the default is "winnt".
Probably the best default would simply be "cmd.exe" as it's invariably in the system path.
Regards, Dave
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-11-06 17:55:57 | Re: psql \! WIN32 cleanup |
| Previous Message | Thomas Hallgren | 2004-11-06 10:53:13 | Re: [PATCHES] CVS should die |