| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Dave Page <dpage(at)vale-housing(dot)co(dot)uk> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: psql \! WIN32 cleanup |
| Date: | 2004-11-06 17:55:57 |
| Message-ID: | 200411061755.iA6Htv112939@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Dave Page wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> The attached applied patch tests for COMSPEC in the right place and
> >> supplies a reasonable shell default on Win32.
> >>
> > + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe"
>
> > Is it really a good idea to assume that the Windows installation is on
> > drive C: ?
>
> I think it's worse to assume the installation directory is "windows". On windows 2000 for example, the default is "winnt".
> Probably the best default would simply be "cmd.exe" as it's invariably in the system path.
Agreed. Done.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2004-11-06 18:35:30 | cygwin build failure |
| Previous Message | Dave Page | 2004-11-06 13:12:20 | Re: psql \! WIN32 cleanup |