pgsql: Remove useless check for negative result of ip_addrsize().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove useless check for negative result of ip_addrsize().
Date: 2025-04-10 18:18:22
Message-ID: E1u2wTm-003cyQ-2j@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove useless check for negative result of ip_addrsize().

By inspection, ip_addrsize() can't return a negative result.
(If it could, we'd have way bigger problems elsewhere.)
So delete useless check in network_send(). Most C compilers
are probably perfectly capable of removing this code by
themselves, but it's confusing/misleading.

Bug: #18889
Reported-by: Daniel Elishakov <dan-eli(at)mail(dot)ru>
Discussion: https://postgr.es/m/18889-73d4f19e953a629e@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f27eb0325b7b2cff3b880fa669913693849521dc

Modified Files
--------------
src/backend/utils/adt/network.c | 2 --
1 file changed, 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-04-10 18:50:00 pgsql: Doc: remove long-obsolete advice about generated constraint name
Previous Message Andrew Dunstan 2025-04-10 16:17:19 pgsql: Further cleanup for directory creation on pg_dump/pg_dumpall