| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Further cleanup for directory creation on pg_dump/pg_dumpall |
| Date: | 2025-04-10 16:17:19 |
| Message-ID: | E1u2uad-003c5m-1p@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Further cleanup for directory creation on pg_dump/pg_dumpall
Instead of two separate (and different) implementations, refactor to use
a single common routine.
Along the way, remove use of a hardcoded file permissions constant in
favor of the common project setting for directory creation.
Author: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAKYtNApihL8X1h7XO-zOjznc8Ca66Aevgvhc9zOTh6DBh2iaeA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4170298b6ecff7ce697b81e13d9a81e3b825798c
Modified Files
--------------
src/bin/pg_dump/dumputils.c | 36 ++++++++++++++++++++++++++++++++
src/bin/pg_dump/dumputils.h | 1 +
src/bin/pg_dump/pg_backup_directory.c | 36 ++------------------------------
src/bin/pg_dump/pg_dumpall.c | 39 +----------------------------------
4 files changed, 40 insertions(+), 72 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-04-10 18:18:22 | pgsql: Remove useless check for negative result of ip_addrsize(). |
| Previous Message | Robert Haas | 2025-04-10 13:31:00 | Re: pgsql: Add function to get memory context stats for processes |