From: | John Naylor <john(dot)naylor(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Silence warning in older versions of Valgrind |
Date: | 2025-02-24 11:07:07 |
Message-ID: | E1tmWIl-000Rad-1x@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Silence warning in older versions of Valgrind
Due to misunderstanding on my part, commit 235328ee4 did not go far
enough to silence older versions of Valgrind. For those, it was the bit
scan that was problematic, not the subsequent bit-masking operation. To
fix, use the unaligned path for the trailing bytes. Since we don't have
a bit scan here anymore, also remove some comments and endian-specific
coding around that.
Reported-by: Anton A. Melnikov <a(dot)melnikov(at)postgrespro(dot)ru>
Discussion: https://postgr.es/m/f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec@postgrespro.ru
Backpatch-through: 17
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/fde7c0164ea20433964a0a05a91c5708384a285c
Modified Files
--------------
src/include/common/hashfn_unstable.h | 26 +++-----------------------
1 file changed, 3 insertions(+), 23 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2025-02-24 11:40:39 | pgsql: Move MAX_BACKENDS to procnumber.h |
Previous Message | John Naylor | 2025-02-24 11:06:59 | pgsql: Silence warning in older versions of Valgrind |