pgsql: Silence warning in older versions of Valgrind

From: John Naylor <john(dot)naylor(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Silence warning in older versions of Valgrind
Date: 2025-02-24 11:06:59
Message-ID: E1tmWIc-000RZq-3C@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Silence warning in older versions of Valgrind

Due to misunderstanding on my part, commit 235328ee4 did not go far
enough to silence older versions of Valgrind. For those, it was the bit
scan that was problematic, not the subsequent bit-masking operation. To
fix, use the unaligned path for the trailing bytes. Since we don't have
a bit scan here anymore, also remove some comments and endian-specific
coding around that.

Reported-by: Anton A. Melnikov <a(dot)melnikov(at)postgrespro(dot)ru>
Discussion: https://postgr.es/m/f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec@postgrespro.ru
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0600d276d485a8222eb6b571b08889c9f539e86f

Modified Files
--------------
src/include/common/hashfn_unstable.h | 26 +++-----------------------
1 file changed, 3 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message John Naylor 2025-02-24 11:07:07 pgsql: Silence warning in older versions of Valgrind
Previous Message Michael Paquier 2025-02-24 00:54:46 pgsql: Remove read/sync fields from pg_stat_wal and GUC track_wal_io_ti