From: | Nathan Bossart <nathan(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus |
Date: | 2024-10-07 21:50:11 |
Message-ID: | E1sxvcJ-002bVC-OI@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator. A comment earlier in the function implores us to fully
qualify everything in the query:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
This commit fixes that. While at it, add a newline for consistency
with surrounding code.
Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ce6f27857bba9e380a10365abf798dfbf453cc31
Modified Files
--------------
src/bin/scripts/vacuumdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2024-10-07 22:17:47 | pgsql: Fix test for password hash length limit. |
Previous Message | Nathan Bossart | 2024-10-07 18:52:54 | pgsql: Fix Y2038 issues with MyStartTime. |