From: | Nathan Bossart <nathan(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix Y2038 issues with MyStartTime. |
Date: | 2024-10-07 18:52:54 |
Message-ID: | E1sxsqk-002aMD-IJ@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix Y2038 issues with MyStartTime.
Several places treat MyStartTime as a "long", which is only 32 bits
wide on some platforms. In reality, MyStartTime is a pg_time_t,
i.e., a signed 64-bit integer. This will lead to interesting bugs
on the aforementioned systems in 2038 when signed 32-bit integers
are no longer sufficient to store Unix time (e.g., "pg_ctl start"
hanging). To fix, ensure that MyStartTime is handled as a 64-bit
value everywhere. (Of course, users will need to ensure that
time_t is 64 bits wide on their system, too.)
Co-authored-by: Max Johnson
Discussion: https://postgr.es/m/CO1PR07MB905262E8AC270FAAACED66008D682%40CO1PR07MB9052.namprd07.prod.outlook.com
Backpatch-through: 12
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5d6187d2a28326b3414c394ec4c28c51bb513c44
Modified Files
--------------
contrib/postgres_fdw/option.c | 2 +-
src/backend/utils/error/csvlog.c | 2 +-
src/backend/utils/error/elog.c | 6 +++---
src/backend/utils/error/jsonlog.c | 4 ++--
src/backend/utils/init/miscinit.c | 4 ++--
src/bin/pg_ctl/pg_ctl.c | 2 +-
6 files changed, 10 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2024-10-07 21:50:11 | pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus |
Previous Message | Tom Lane | 2024-10-07 16:31:49 | pgsql: Prepare tab-complete.c for preprocessing. |