pgsql: Fix data loss at inplace update after heap_update().

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix data loss at inplace update after heap_update().
Date: 2024-09-24 22:27:58
Message-ID: E1stE0k-000khx-Bv@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix data loss at inplace update after heap_update().

As previously-added tests demonstrated, heap_inplace_update() could
instead update an unrelated tuple of the same catalog. It could lose
the update. Losing relhasindex=t was a source of index corruption.
Inplace-updating commands like VACUUM will now wait for heap_update()
commands like GRANT TABLE and GRANT DATABASE. That isn't ideal, but a
long-running GRANT already hurts VACUUM progress more just by keeping an
XID running. The VACUUM will behave like a DELETE or UPDATE waiting for
the uncommitted change.

For implementation details, start at the systable_inplace_update_begin()
header comment and README.tuplock. Back-patch to v12 (all supported
versions). In back branches, retain a deprecated heap_inplace_update(),
for extensions.

Reported by Smolkin Grigory. Reviewed by Nitin Motiani, (in earlier
versions) Heikki Linnakangas, and (in earlier versions) Alexander
Lakhin.

Discussion: https://postgr.es/m/CAMp+ueZQz3yDk7qg42hk6-9gxniYbp-=bG2mgqecErqR5gGGOA@mail.gmail.com

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fd27b878c2ea54b6132758084270cb13e5e66f2e

Modified Files
--------------
src/backend/access/heap/README.tuplock | 11 +
src/backend/access/heap/heapam.c | 254 +++++++++++++++--
src/backend/access/index/genam.c | 139 ++++++++++
src/backend/catalog/index.c | 38 +--
src/backend/catalog/toasting.c | 30 ++-
src/backend/commands/dbcommands.c | 34 +--
src/backend/commands/event_trigger.c | 27 +-
src/backend/commands/vacuum.c | 32 ++-
src/include/access/genam.h | 9 +
src/include/access/heapam.h | 7 +
.../isolation/expected/intra-grant-inplace-db.out | 10 +-
.../isolation/expected/intra-grant-inplace.out | 16 +-
.../isolation/specs/intra-grant-inplace-db.spec | 1 -
src/test/isolation/specs/intra-grant-inplace.spec | 4 +-
.../modules/injection_points/expected/inplace.out | 299 ++++++++++++++++++++-
.../modules/injection_points/specs/inplace.spec | 74 ++++-
16 files changed, 862 insertions(+), 123 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2024-09-24 22:27:59 pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.
Previous Message Jeff Davis 2024-09-24 22:18:49 pgsql: Allow length=-1 for NUL-terminated input to pg_strncoll(), etc.