pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.
Date: 2024-09-24 22:27:59
Message-ID: E1stE0k-000kiY-Hi@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.

The current use always releases this locktag. A planned use will
continue that intent. It will involve more areas of code, making unlock
omissions easier. Warn under debug_assertions, like we do for various
resource leaks. Back-patch to v12 (all supported versions), the plan
for the commit of the new use.

Reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5ef9b4a2f79670a1cf9649e568fba7920a72e9a4

Modified Files
--------------
src/backend/storage/lmgr/lock.c | 10 ++++++++++
1 file changed, 10 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-09-24 23:57:20 Re: pgsql: Allow meson builds to run test_pg_dump test in installcheck mode
Previous Message Noah Misch 2024-09-24 22:27:58 pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.