pgsql: Use xmlAddChildList not xmlAddChild in XMLSERIALIZE.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use xmlAddChildList not xmlAddChild in XMLSERIALIZE.
Date: 2024-07-06 19:16:33
Message-ID: E1sQAtd-000bHU-Al@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use xmlAddChildList not xmlAddChild in XMLSERIALIZE.

It looks like we should have been doing this all along,
but we got away with the wrong coding until libxml2 2.13.0
tightened up xmlAddChild's behavior.

There is more stuff to be fixed to be compatible with 2.13.0,
and it will all need to be back-patched. This is just a
trial commit to see if the buildfarm agrees that we can use
xmlAddChildList unconditionally.

Erik Wienhold, per report from Frank Streitzig.

Discussion: https://postgr.es/m/trinity-b0161630-d230-4598-9ebc-7a23acdb37cb-1720186432160@3c-app-gmx-bap25
Discussion: https://postgr.es/m/trinity-361ba18b-541a-4fe7-bc63-655ae3a7d599-1720259822452@3c-app-gmx-bs01

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/066e8ac6ea8bc2af79dc86273a09ba7c1a39f7fd

Modified Files
--------------
src/backend/utils/adt/xml.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-07-08 00:45:18 pgsql: Re-enable autoruns for cmd.exe on Windows
Previous Message David Rowley 2024-07-06 05:40:35 pgsql: Adjust tuplestore.c not to allocate BufFiles in generation conte