pgsql: Adjust tuplestore.c not to allocate BufFiles in generation conte

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Adjust tuplestore.c not to allocate BufFiles in generation conte
Date: 2024-07-06 05:40:35
Message-ID: E1sPy9x-000VqY-Ri@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Adjust tuplestore.c not to allocate BufFiles in generation context

590b045c3 made it so tuplestore.c would store tuples inside a
generation.c memory context. After fixing a bug report in 97651b013, it
seems that it's probably best not to allocate BufFile related
allocations in that context. Let's keep it just for tuple data.

This adjusts the code to switch to the Tuplestorestate.context's parent,
which is the MemoryContext that tuplestore_begin_common() was called in.
It does not seem worth adding a new field in Tuplestorestate to store
this when we can access it by looking at the Tuplestorestate's
context's parent.

Discussion: https://postgr.es/m/CAApHDvqFt_CdJtSr+E9YLZb7jZAyRCy3hjQ+ktM+dcOFVq-xkg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/04bcf9e19a4261fe9c7df37c777592c2e10c32a7

Modified Files
--------------
src/backend/utils/sort/tuplestore.c | 10 ++++++++++
1 file changed, 10 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-07-06 19:16:33 pgsql: Use xmlAddChildList not xmlAddChild in XMLSERIALIZE.
Previous Message David Rowley 2024-07-06 02:00:46 pgsql: Fix incorrect sentinel byte logic in GenerationRealloc()