| From: | Robert Haas <rhaas(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Use tempdir_short instead of tempdir. |
| Date: | 2024-04-19 19:59:38 |
| Message-ID: | E1rxuOX-002tRe-Vk@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Use tempdir_short instead of tempdir.
After cd64dc42d1e1b03e57e6ba3d316e4f9dec52a78d, a significant
percentage of the buildfarm got unhappy, because pg_basebackup chokes
if it tries to create a tarfile with symlink more than 99 characters
in length. To try to fix that problem, use tempdir_short instead of
tempdir, as we do in pg_verifybackup's 003_corruption.pl.
There's a more complicated workaround for the same issue in
pg_basebackup's 010_pg_basebackup.pl, but I'm not clear whether
there's any reason to do it that way here. For now, let's try this,
to at least get the buildfarm green again.
A better long-term fix would be to figure out how to generate tar
files containing long symlinks, but that will have to wait for
another time.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fa7036dd6644d13233b475874a94754a5903e35a
Modified Files
--------------
src/bin/pg_combinebackup/t/002_compare_backups.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-04-19 21:24:10 | pgsql: Revert recent ill-advised test case changes. |
| Previous Message | Robert Haas | 2024-04-19 17:42:12 | pgsql: pg_combinebackup: Fix incorrect tablespace handling. |